add "tractionBatteryCapacity" property (VehicleModel)#275
Open
andreasDroid wants to merge 1 commit intosmart-data-models:masterfrom
Open
add "tractionBatteryCapacity" property (VehicleModel)#275andreasDroid wants to merge 1 commit intosmart-data-models:masterfrom
andreasDroid wants to merge 1 commit intosmart-data-models:masterfrom
Conversation
|
@albertoabellagarcia: Please let us know if some of the guidelines for getting a PR accepted is not followed correctly for this PR... Hoping to get the dialgoue started soon! |
albertoabellagarcia
requested changes
Feb 16, 2026
Contributor
albertoabellagarcia
left a comment
albertoabellagarcia
left a comment
There was a problem hiding this comment.
Address the changes and include the examples extended
Contributor
There was a problem hiding this comment.
although this is correct you need to include the examples to demonstrate that the data model is actually in use
Contributor
There was a problem hiding this comment.
contribution manual https://bit.ly/contribution_manual
Contributor
Author
There was a problem hiding this comment.
Great, thank you @albertoabellagarcia.
I have added examples where tractionBatteryCapacity is relevant along with the fuelConsumption.
andreasDroid
force-pushed
the
tractionBatteryCapacity
branch
from
d763cbb to
1c074dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to accept a
tractionBatteryCapacityvalue in the VehicleModel.Adopters will be a project funded by OS2.eu, an open source community for danish municipalities. The project aims to allow municipalities to collect GPS data from their fleet.
Specifically applicable for enabling further analaysis and optimisation on the fleet by calculating range from battery capacity of BEV.
As of now, there are no immediate value that is suitable for containing this information.
We suggest a new property that will be dedicated to store the capacity of the battery for vehicles that are fully or partly powered by a traction battery.
Example files are left out of this commit as
tractionBatteryCapacityis not applicable on the included example. Let me know if you want the example files to include the new property.Contribution agreement has been signed with my user @andreasDroid
We wish to appear in the
CONTRIBUTORS.yamlas organisation and not as a specific individual.