Feature - sidebar keeps plus button on large screens for new sessions#233
Closed
ahundt wants to merge 2 commits intoslopus:mainfrom
Closed
Feature - sidebar keeps plus button on large screens for new sessions#233ahundt wants to merge 2 commits intoslopus:mainfrom
ahundt wants to merge 2 commits intoslopus:mainfrom
Conversation
Previous behavior: - Narrow mode: + button in header top right - Large screen mode: + button missing from header row What changed: - Added Ionicons add-outline import (line 17) - Added + button Pressable after settings button (line 241) - Button positioned in rightContainer with inbox and settings - Routes to /new on press (creates new session) Why: Large screen users need header access to create new sessions, matching narrow mode UX pattern. Files affected: - sources/components/SidebarView.tsx: Added import and button in header Technical details: - Uses Ionicons add-outline size 28 (identical to narrow mode HomeHeader.tsx:128) - Reuses existing handleNewSession callback - 7 lines added (1 import, 6 button JSX)
ahundt
changed the title
ahundt
changed the title
Contributor
Author
|
this was merged as part of #272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SidebarView.tsx: add + button to header in large screen mode
Previous behavior:
Now the plus button stays where it is if you are on ipad or desktop!
Previous Behavior: plus button is missing, should be to right of "Happy"
What changed:
Why:
Large screen users need header access to create new sessions, matching narrow mode UX pattern.
Files affected:
Technical details: