Remove workflow namespace concept; use flat IDs#9
Merged
justinmoon merged 1 commit intomasterfrom Mar 4, 2026
Merged
Conversation
Workflow IDs were unnecessarily namespaced as "namespace/name" (e.g., "builtin/plan", "demo/negotiate") but the namespace served no real purpose — all workflows are registered identically and the "builtin" distinction was vestigial from before workflows were extracted into their own crates. - Flatten all workflow IDs: builtin/plan→plan, builtin/build→build, builtin/consult→consult, demo/negotiate→negotiate, builtin/hello→hello - Simplify WorkflowId::parse() to accept flat [a-z0-9_-] names - Remove is_builtin_workflow_id() guard and the "builtin" concept - Remove dead workflow_source field from SessionState - Rename constants: BUILTIN_*_WORKFLOW_ID → *_WORKFLOW_ID Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builtin/plan→plan,demo/negotiate→negotiate, etc.is_builtin_workflow_id()guard — the "builtin" concept no longer existsworkflow_sourcefield fromSessionState(was set but never read)WorkflowId::parse()to accept flat[a-z0-9_-]namesrally workflow listnow outputs clean names:build,consult,hello,negotiate,planTest plan
builtin/,demo/, or old constant names🤖 Generated with Claude Code