Skip to content

Refactor wrapper surface to skill and externalize prompts#15

Merged
justinmoon merged 6 commits intomasterfrom
tweaks
Mar 4, 2026
Merged

Refactor wrapper surface to skill and externalize prompts#15
justinmoon merged 6 commits intomasterfrom
tweaks

Conversation

@justinmoon
Copy link
Copy Markdown
Contributor

@justinmoon justinmoon commented Mar 4, 2026

Summary

  • simplify installed /rally wrapper files to a stable stub that calls rally skill agent-howto
  • rename wrapper namespace from rally command ... to rally skill ... (with command as a compatibility alias)
  • move prompt content into centralized markdown templates under prompts/
  • update docs/tests/scripts to the new skill surface and context store naming

Verification

  • cargo test -q

Summary by CodeRabbit

Release Notes

  • New Features

    • Renamed CLI command suite from rally command to rally skill (install, run, exec, doctor, uninstall)
    • Added rally skill agent-howto for interactive agent-guided workflows
  • Documentation

    • Updated all examples and guides to reflect new Skill command terminology
  • Chores

    • Enhanced test matrix infrastructure and environment setup

justinmoon and others added 6 commits March 3, 2026 21:07
Replace per-target wrapper format (commands/rally.md, prompts/rally.md)
with unified SKILL.md using YAML frontmatter across all agents. Remove
rally-target field (skills are target-independent). Add legacy path
cleanup on install/uninstall. Add python3 to devShell and concurrent
e2e_matrix.py test harness with wave scheduling.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 4, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR renames the "Command Wrappers" surface to "Skill Wrappers" throughout the codebase. Changes include CLI subcommand restructuring, API signature updates across core modules, documentation rewrites, test flow migrations, new skill-based prompt templates, and a Python-based end-to-end test matrix runner.

Changes

Cohort / File(s) Summary
CLI Surface & Core API
src/cli.rs, src/command_surface.rs, src/lib.rs
Renamed Command enum variants and argument types (CommandCommandArgs → SkillCommandArgs, CommandSubcommand → SkillSubcommand, etc.). Introduced new SkillAgentHowtoArgs struct and agent_howto() function. Updated HarnessTarget to remove Factory variant and add legacy path handling. Renamed context file from command-context.json to skill-context.json with legacy fallback. Updated template constants and ownership model logic.
Documentation & Prompts
README.md, docs/skill-install-run.md, docs/manual-qa-skill-install-run.md, prompts/skill-wrapper.md, prompts/skill-agent-howto.md
Replaced all "command" references with "skill" in documentation and examples. Updated file paths from ~/.codex/commands/ to ~/.codex/skills/, renamed context files, and added new skill-specific workflow documentation. Added new prompt templates for skill-wrapper and skill-agent-howto flows.
Test Suite
tests/command_install_run.rs, tests/e2e-agents.sh, tests/e2e-implement.sh, tests/e2e_matrix.py
Updated CLI invocations from "rally command..." to "rally skill...". Migrated test flows to use SkillInstallArgs and SkillRunArgs types. Changed file assertions to expect SKILL.md locations. Added new comprehensive Python-based e2e test matrix runner with concurrent solo/pair test execution and structured result reporting (465 lines).
Configuration & Metadata
.gitignore, flake.nix, justfile, todos/run-cmd-test.md, todos/run-commands.md
Added test artifact patterns to .gitignore (solo-.txt, e2e-.txt, etc.). Added pkgs.python3 to devShell. Replaced test-implement target with test-matrix target accepting variadic arguments. Updated todo specs from "command run" to "skill run" dispatch.
Test Output Artifacts
solo-claude-1772595331697.txt, solo-codex-1772595331697.txt, solo-pi-1772595331697.txt
Added minimal test output files; likely generated by test execution and covered by .gitignore patterns.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A skill's rebrand, from command's old ways,
Now rally hops through skill-based maze!
With agent-howto and SKILL.md bright,
The wrappers leap—refactored right! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 29.58% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Refactor wrapper surface to skill and externalize prompts' directly reflects the main changes: renaming the wrapper namespace from command to skill and moving prompt content into centralized markdown templates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tweaks

Comment @coderabbitai help to get the list of available commands and usage tips.

@justinmoon justinmoon merged commit fb26230 into master Mar 4, 2026
1 of 3 checks passed
@justinmoon justinmoon deleted the tweaks branch March 4, 2026 04:16
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant