refactor: remove survey package and permanently enable huh prompts #425
+31
−450
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,21 @@ import ( | |
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/slackapi/slack-cli/internal/slackerror" | ||
| "github.com/slackapi/slack-cli/internal/style" | ||
| "github.com/spf13/pflag" | ||
| ) | ||
|
|
||
| // MimicInputPrompt formats a message and value to appear as a prompted input | ||
| func MimicInputPrompt(message string, value string) string { | ||
| return fmt.Sprintf( | ||
| "%s %s %s", | ||
| style.Darken("?"), | ||
| style.Highlight(message), | ||
| style.Input(value), | ||
| ) | ||
| } | ||
|
|
||
|
Comment on lines
+29
to
+38
Member
There was a problem hiding this comment. question: Why was this added? A quick search doesn't show that it's called anywhere. Since this PR is focused on removing survey, if we need to add
Contributor
Author
There was a problem hiding this comment. its used in @add.go
Member
There was a problem hiding this comment. 🪓 @srtaalej This is alright to remove IIRC - it was included with survey as a placeholder output for the following command in particular: 
👾 ramble: We wanted this to mimic the input form with an argument, but now that forms disappear we might be alright to remove this too: Lines 106 to 112 in 0c37128 |
||
| // PromptConfig contains general information about a prompt | ||
| type PromptConfig interface { | ||
| GetFlags() []*pflag.Flag // GetFlags returns all flags for the prompt | ||
|
|
@@ -193,28 +203,19 @@ func errInteractivityFlags(cfg PromptConfig) error { | |
| // ConfirmPrompt prompts the user for a "yes" or "no" (true or false) value for | ||
| // the message | ||
| func (io *IOStreams) ConfirmPrompt(ctx context.Context, message string, defaultValue bool) (bool, error) { | ||
| return confirmForm(io, ctx, message, defaultValue) | ||
| } | ||
|
|
||
| // InputPrompt prompts the user for a string value for the message, which can | ||
| // optionally be made required | ||
| func (io *IOStreams) InputPrompt(ctx context.Context, message string, cfg InputPromptConfig) (string, error) { | ||
| return inputForm(io, ctx, message, cfg) | ||
| } | ||
|
|
||
| // MultiSelectPrompt prompts the user to select multiple values in a list and | ||
| // returns the selected values | ||
| func (io *IOStreams) MultiSelectPrompt(ctx context.Context, message string, options []string) ([]string, error) { | ||
| return multiSelectForm(io, ctx, message, options) | ||
| } | ||
|
|
||
| // PasswordPrompt prompts the user with a hidden text input for the message | ||
|
|
@@ -229,10 +230,7 @@ func (io *IOStreams) PasswordPrompt(ctx context.Context, message string, cfg Pas | |
| return PasswordPromptResponse{}, errInteractivityFlags(cfg) | ||
| } | ||
|
|
||
| return passwordForm(io, ctx, message, cfg) | ||
| } | ||
|
|
||
| // SelectPrompt prompts the user to make a selection and returns the choice | ||
|
|
@@ -257,8 +255,5 @@ func (io *IOStreams) SelectPrompt(ctx context.Context, msg string, options []str | |
| } | ||
| } | ||
|
|
||
| return selectForm(io, ctx, msg, options, cfg) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ question: Can this be checked within
iostreams.MatchPromptConfigor does this assert something about the orderings?