Skip to content

Fix GitHub Actions workflow failure #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyelaird merged 1 commit into from
Nov 18, 2025
Merged

Fix GitHub Actions workflow failure #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions .github/workflows/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,32 +75,32 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY

if [ -f validation_reference_results.json ]; then
python -c '
python -c "
import json
import sys

with open("validation_reference_results.json") as f:
with open('validation_reference_results.json') as f:
results = json.load(f)

summary = results["summary"]
targets = results["targets"]
summary = results['summary']
targets = results['targets']

print(f"**Test Cases Run:** {summary[\"test_cases_run\"]}")
print(f"**Total Comparisons:** {summary[\"total\"]}")
print(f"**Passed:** {summary[\"passed\"]} ({summary[\"pass_rate\"]:.1f}%)")
print(f"**Failed:** {summary[\"failed\"]}")
print(f\"**Test Cases Run:** {summary['test_cases_run']}\")
print(f\"**Total Comparisons:** {summary['total']}\")
print(f\"**Passed:** {summary['passed']} ({summary['pass_rate']:.1f}%)\")
print(f\"**Failed:** {summary['failed']}\")
print()

pass_rate = summary["pass_rate"]
if pass_rate >= targets["excellent_pass_rate"]:
print(f"✅ **EXCELLENT** - Pass rate {pass_rate:.1f}% exceeds target {targets[\"excellent_pass_rate\"]}%")
elif pass_rate >= targets["target_pass_rate"]:
print(f"✅ **VERY GOOD** - Pass rate {pass_rate:.1f}% exceeds target {targets[\"target_pass_rate\"]}%")
elif pass_rate >= targets["minimum_pass_rate"]:
print(f"✅ **PASSED** - Pass rate {pass_rate:.1f}% meets minimum {targets[\"minimum_pass_rate\"]}%")
pass_rate = summary['pass_rate']
if pass_rate >= targets['excellent_pass_rate']:
print(f\"✅ **EXCELLENT** - Pass rate {pass_rate:.1f}% exceeds target {targets['excellent_pass_rate']}%\")
elif pass_rate >= targets['target_pass_rate']:
print(f\"✅ **VERY GOOD** - Pass rate {pass_rate:.1f}% exceeds target {targets['target_pass_rate']}%\")
elif pass_rate >= targets['minimum_pass_rate']:
print(f\"✅ **PASSED** - Pass rate {pass_rate:.1f}% meets minimum {targets['minimum_pass_rate']}%\")
else:
print(f"❌ **BELOW TARGET** - Pass rate {pass_rate:.1f}% below minimum {targets[\"minimum_pass_rate\"]}%")
' >> $GITHUB_STEP_SUMMARY
print(f\"❌ **BELOW TARGET** - Pass rate {pass_rate:.1f}% below minimum {targets['minimum_pass_rate']}%\")
" >> $GITHUB_STEP_SUMMARY
else
echo "❌ Validation failed to produce results" >> $GITHUB_STEP_SUMMARY
fi
Expand Down