Add ephemeral keypair pool for noise handshakes#351
Merged
0pcom merged 2 commits intoskycoin:developfrom Mar 25, 2026
Merged
Conversation
Pre-generate secp256k1 keypairs in a background goroutine and serve them from a buffered channel pool. This eliminates the per-handshake cost of EC key generation under load, allowing burst handling of concurrent handshakes without blocking on crypto operations.
- Eliminate per-encrypt nonce buffer allocation by using a reusable [8]byte field in the Noise struct - Pre-allocate output buffer in EncryptUnsafe to avoid append growth - Add sync.Pool for write frame buffers to reduce allocation pressure - Skip redundant NewPubKey/NewSecKey validation in DH() since keys are already validated by the noise state machine (ECDH still validates) - Skip cipher.NewPubKey validation in RemoteStatic() since the key was already verified during the handshake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-generate secp256k1 keypairs in a background goroutine and serve them from a buffered channel pool. This eliminates the per-handshake cost of EC key generation under load, allowing burst handling of concurrent handshakes without blocking on crypto operations.