Skip to content

[BUG] Fix missing raise before TypeError in Pipeline._check_steps#807

Open
Sanchit2662 wants to merge 1 commit intosktime:mainfrom
Sanchit2662:fix/missing-raise-pipeline-check
Open

[BUG] Fix missing raise before TypeError in Pipeline._check_steps#807
Sanchit2662 wants to merge 1 commit intosktime:mainfrom
Sanchit2662:fix/missing-raise-pipeline-check

Conversation

@Sanchit2662
Copy link

Description

--- I found a missing raise keyword in the pipeline validation logic that was silently allowing invalid configurations to pass through.

In skpro/regression/compose/_pipeline.py, line 111 was creating a TypeError but never raising it. This meant if someone built a pipeline with a transformer as the last step (when allow_postproc=False), the validation would just skip over the error instead of failing.

Fix

Added raise before the TypeError on line 111. Now invalid pipelines properly raise an exception instead of silently succeeding and breaking later during fit/predict.

It's a one-word fix that aligns with the two other validation checks in the same method which already use raise correctly. Pretty straightforward catch.

Signed-off-by: Sanchit2662 <sanchit2662@gmail.com>
@Sanchit2662
Copy link
Author

Hi @fkiraly , please look review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant