[BUG] Fix missing raise before TypeError in Pipeline._check_steps#807
Open
Sanchit2662 wants to merge 1 commit intosktime:mainfrom
Open
[BUG] Fix missing raise before TypeError in Pipeline._check_steps#807Sanchit2662 wants to merge 1 commit intosktime:mainfrom
Sanchit2662 wants to merge 1 commit intosktime:mainfrom
Conversation
Signed-off-by: Sanchit2662 <sanchit2662@gmail.com>
Author
|
Hi @fkiraly , please look review the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--- I found a missing raise keyword in the pipeline validation logic that was silently allowing invalid configurations to pass through.
In
skpro/regression/compose/_pipeline.py, line 111was creating a TypeError but never raising it. This meant if someone built a pipeline with a transformer as the last step (when allow_postproc=False), the validation would just skip over the error instead of failing.Fix
Added raise before the TypeError on line 111. Now invalid pipelines properly raise an exception instead of silently succeeding and breaking later during fit/predict.
It's a one-word fix that aligns with the two other validation checks in the same method which already use raise correctly. Pretty straightforward catch.