[ENH] enhance Fisk distribution with closed-form mean/var/pdf/cdf/ppf…#806
Open
Shristimishra980 wants to merge 1 commit intosktime:mainfrom
Open
[ENH] enhance Fisk distribution with closed-form mean/var/pdf/cdf/ppf…#806Shristimishra980 wants to merge 1 commit intosktime:mainfrom
Shristimishra980 wants to merge 1 commit intosktime:mainfrom
Conversation
…fixes sktime#22 - Fix docstring: correct CDF formula (removed malformed LaTeX, added proper formulas) - Add explicit _mean: alpha*pi/beta / sin(pi/beta) [defined for beta > 1] - Add explicit _var: closed-form formula [defined for beta > 2] - Add explicit _pdf: (beta/alpha)*(x/alpha)^(beta-1) / (1 + (x/alpha)^beta)^2 - Add explicit _log_pdf: log of closed-form PDF - Add explicit _cdf: (x/alpha)^beta / (1 + (x/alpha)^beta) - Add explicit _ppf: alpha * (p/(1-p))^(1/beta) -- analytical closed form - Add full math documentation with LaTeX formulas in docstring - Add dedicated test_fisk.py with mean/var/pdf/cdf/ppf/log_pdf correctness tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, fixes #22
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.