Skip to content

[ENH] Add _log_pdf method to Uniform distribution#800

Open
Nadjoubiii wants to merge 1 commit intosktime:mainfrom
Nadjoubiii:fix-uniform-log-pdf
Open

[ENH] Add _log_pdf method to Uniform distribution#800
Nadjoubiii wants to merge 1 commit intosktime:mainfrom
Nadjoubiii:fix-uniform-log-pdf

Conversation

@Nadjoubiii
Copy link

  • Implements mathematically exact log_pdf for uniform distribution
  • Returns -log(b-a) for in-bounds points, -inf for out-of-bounds
  • Eliminates numpy warnings from log(0) by using np.where
  • Fulfills already-declared exact capability tag

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

- Implements mathematically exact log_pdf for uniform distribution
- Returns -log(b-a) for in-bounds points, -inf for out-of-bounds
- Eliminates numpy warnings from log(0) by using np.where
- Fulfills already-declared exact capability tag
@Nadjoubiii Nadjoubiii force-pushed the fix-uniform-log-pdf branch from bb941e2 to 10bb21a Compare March 5, 2026 21:54
@Nadjoubiii Nadjoubiii changed the title Added _log_pdf method to Uniform distribution [ENH] Add _log_pdf method to Uniform distribution Mar 5, 2026
@arnavk23
Copy link
Contributor

arnavk23 commented Mar 6, 2026

There is already a pr for this i.e. #787. Please close this pr and try to look for issues under good first issue and enhancement which haven't been worked on before by contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants