Skip to content

[ENH] interfacing Binomial regressor from sklearn LogisticRegression#795

Open
itspriiyanshu wants to merge 2 commits intosktime:mainfrom
itspriiyanshu:BinomialLink
Open

[ENH] interfacing Binomial regressor from sklearn LogisticRegression#795
itspriiyanshu wants to merge 2 commits intosktime:mainfrom
itspriiyanshu:BinomialLink

Conversation

@itspriiyanshu
Copy link

@itspriiyanshu itspriiyanshu commented Mar 4, 2026

Reference Issues/PRs

Towards #7

What does this implement/fix? Explain your changes.

Added interface for Binomial Regressor using sklearn.linear_model.LogisticRegression

Does your contribution introduce a new dependency? If yes, which one?

None

Did you add any tests for the change?

None

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

Copy link
Contributor

@arnavk23 arnavk23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itspriiyanshu Please remove the pycache files. The only files that should be here are regression.rst, __init.py, _sklearn_binomial.py.
Also update pr description. This does not fix the umbrella issue #7 but is towards it. Change Fixes to Towards.

@itspriiyanshu
Copy link
Author

@arnavk23 Please have a look, I've implemented the suggested changes. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants