[BUG] Fix Pipeline._transform not chaining transformer outputs#790
Open
WHOIM1205 wants to merge 1 commit intosktime:mainfrom
Open
[BUG] Fix Pipeline._transform not chaining transformer outputs#790WHOIM1205 wants to merge 1 commit intosktime:mainfrom
WHOIM1205 wants to merge 1 commit intosktime:mainfrom
Conversation
Signed-off-by: WHOIM1205 <rathourprateek8@gmail.com>
Contributor
Author
|
@fkiraly |
Contributor
Author
so should i close this ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix
Pipeline._transformto correctly chain transformer outputs during predictionSummary
This PR fixes a critical bug in
Pipeline._transformwhere transformer outputs were not chained during inference.Previously, each transformer in the pipeline received the original, untransformed
X, and only the last transformer's output (applied to raw input) was passed to the regressor.This caused:
predict_proba,predict_interval,predict_quantiles,predict_var)UnboundLocalErrorfor regressor-only pipelines (0 transformers)The fix mirrors the chaining logic already used in
_fitby reassigningXinside the loop.Root Cause
In
_transform, the output of each transformer was assigned toXt, butXwas never updated: