[ENH] class based tag system (#767)#770
Open
Abhishek9639 wants to merge 4 commits intosktime:mainfrom
Open
Conversation
Author
|
Hi @fkiraly and @felipeangelimvieira, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #767
What does this implement/fix? Explain your changes.
Replaces skpro's legacy list-of-tuples tag register with a class-based tag system, matching sktime's architecture. Each tag is now a _BaseTag subclass with docstrings. The OBJECT_TAG_REGISTER is auto-constructed via introspection at module bottom. Fully backward compatible.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes, added two new tests:
Any other comments?
This is a prerequisite for #768 (tag documentation). The existing test test_tag_register_type also passes unchanged, confirming backward compatibility.
PR checklist