MNT: reduce scope of test_get_package_metadata_returns_expected_results to mock_package#516
Open
shourya1419-netizen wants to merge 1 commit intosktime:mainfrom
Open
Conversation
…ts to mock_package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduces the scope of test_get_package_metadata_returns_expected_results so that it runs against the mock_package used in lookup tests instead of the entire skbase package.
Why is this needed?
Currently the test relies on the full skbase module list. Adding new modules or classes to skbase can cause unrelated failures in this test because expected module/function lists are hardcoded.
What is changed?
1)The test now calls get_package_metadata on skbase.lookup.tests.mock_package.
2)Removed dependency on SKBASE_MODULES and SKBASE_PUBLIC_MODULES.
3)Assertions now validate the structure of returned metadata instead of comparing against global module constants.
Result
This makes the test independent of unrelated changes in skbase modules while still verifying that get_package_metadata correctly returns functions and classes.
fixes #114