Open
Conversation
- Replace isort, black, flake8 with ruff in pre-commit hooks - Add ruff configuration to pyproject.toml - Update linters dependencies - Format and fix code with ruff
40df124 to
ac62a6d
Compare
for more information, see https://pre-commit.ci
…2, SIM201, SIM103
for more information, see https://pre-commit.ci
…PIE810, RUF012, SIM102, SIM201, SIM103, SIM117, B018, D401, B904, RUF043 in some
Contributor
Author
|
@fkiraly Please review this pr. Focus only on the precommit file as the rest changes are caused by moving to ruff. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 85.07% 83.73% -1.35%
==========================================
Files 45 52 +7
Lines 3015 3854 +839
==========================================
+ Hits 2565 3227 +662
- Misses 450 627 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ruff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #502
What does this implement/fix? Explain your changes.
This PR migrates the
pre-commitconfiguration to useruffas the unified tool for code formatting and linting, replacing the separateisort,black, andflake8hooks. This alignsskbasewithsktimeand other GC.OS repositories for consistency and performance.Does your contribution introduce a new dependency? If yes, which one?
Yes,
ruffis added as a new dependency in thelintersoptional dependencies group inpyproject.toml. This is necessary to replace the functionality ofisort,black, andflake8, providing a single, efficient tool for linting and formatting.What should a reviewer concentrate their feedback on?
pyproject.toml(rules, ignores, excludes)..pre-commit-config.yamlAny other comments?
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions