feat(persistent): Cosmos persistent load test metrics recording#64
feat(persistent): Cosmos persistent load test metrics recording#64
Conversation
Greptile SummaryThis PR adds Prometheus broadcast-success/failure counters and a 30-second TPS logging tracker to the Cosmos persistent load test runner, mirroring patterns already used in the Ethereum runner. The runner integration is clean, but there is a critical registration issue in the new metrics package.
Confidence Score: 2/5
Important Files Changed
Last reviewed commit: 091fe76 |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
@greptile rearview knowing that when running catalyst, only a single runner is ever created for this instance of catalyst, so the duplicate registration callout is not an issue. |
|
Got it - that makes sense. Since there's only one runner per Catalyst instance, the duplicate registration concern doesn't apply here. If this single-runner-per-instance constraint isn't immediately obvious from the code or project structure, it might be worth a brief comment noting that assumption, especially if the registry is shared/global. But if it's well-understood in your architecture, feel free to disregard. |
Closes: STACK-2504