This repository was archived by the owner on Jan 31, 2025. It is now read-only.
refactor(abci/checktx): remove duplication and simplify the code#493
Open
EmilGeorgiev wants to merge 3 commits intoskip-mev:mainfrom
Open
refactor(abci/checktx): remove duplication and simplify the code#493EmilGeorgiev wants to merge 3 commits intoskip-mev:mainfrom
EmilGeorgiev wants to merge 3 commits intoskip-mev:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
+ Coverage 52.07% 53.04% +0.97%
==========================================
Files 48 48
Lines 1855 1804 -51
==========================================
- Hits 966 957 -9
+ Misses 798 756 -42
Partials 91 91 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplication and simplifies the code:
is replaced with
The CheckTx method of MempoolParityCheckTx only check transactions if the check Tx type is 'ReCheck'. If the check type is different, it immediately proceeds to the next checkTxHandler. This approach avoids redundant checks and logic, such as decoding the transaction, which is duplicated across all checkTxHandlers. It also eliminates the need to call isInvalidCheckTxExecution.
By checking the mode of the check transaction at the beginning of the CheckTx method, additional checks in the if statements can be avoided. For example:
Now is simpliefied and looks like:
And
is now:
Removed the check for whether the mempool contains the transaction before deleting it because the Remove method already performs this check, making it redundant.
Adjust method and function comments to aligns with Go best practices.