Address code review feedback for large payload tests#30
Closed
Copilot wants to merge 2 commits intopayload-validation-tests-10150719905609723466from
Closed
Address code review feedback for large payload tests#30Copilot wants to merge 2 commits intopayload-validation-tests-10150719905609723466from
Copilot wants to merge 2 commits intopayload-validation-tests-10150719905609723466from
Conversation
…s, and clean up Co-authored-by: CypherPotato <17441745+CypherPotato@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add large payload validation tests to Sisk.Core
Address code review feedback for large payload tests
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on the large payload validation tests PR to fix build warnings, improve parallelization behavior, and align with project conventions.
Changes:
TreatWarningsAsErrors[DoNotParallelize]to prevent OOM/timeout when 500MB+ tests run concurrently under 4-worker parallel execution[Timeout]attributes to all test methods (5min for ≤100MB, 10min for ≥500MB)tests.Testsmatching other test filesRandomStreaminternal sealed per test assembly conventionsSystem.Text,Sisk.Cadente)ListeningPort.GetRandomPort()instead of custom TCP listener logicSisk.Cadenteproject reference (available transitively)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.