Skip to content

Add theme: Open in Container Window#700

Open
github-actions[bot] wants to merge 1 commit intomainfrom
mod/open-in-container-window
Open

Add theme: Open in Container Window#700
github-actions[bot] wants to merge 1 commit intomainfrom
mod/open-in-container-window

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Add theme: Open in Container Window

This PR adds a new theme to the marketplace.

Theme Details

@CosmoCreeper
Copy link
Copy Markdown
Contributor

Just a few questions if you don't mind:

  • Is this mod built heavily or partially with AI? If so, we will still allow it but it is requested that you specify an ai property in your theme.json file with a value of "partial" or "yes" depending on how much of your program was built solely with AI.
  • There is a bug I noticed that appears quite odd. The text for the Open in Container Window option appears twice (as shown in the picture below).
image

@GitDevEnv
Copy link
Copy Markdown
Collaborator

@t4nk3rchu are you there? Please answer the queries raised by CosmoCreeper.

@t4nk3rchu
Copy link
Copy Markdown

Just a few questions if you don't mind:

* Is this mod built heavily or partially with AI? If so, we will still allow it but it is requested that you specify an `ai` property in your theme.json file with a value of `"partial"` or `"yes"` depending on how much of your program was built solely with AI.

* There is a bug I noticed that appears quite odd. The text for the `Open in Container Window` option appears twice (as shown in the picture below).
image

oh shoot! I've seen that a few times but i thought i fixed it
And yeh this is made with AI (solely)
I will put in the ai property in the theme.json
But is there a template like how to put the property in the theme.json properly?

@CosmoCreeper
Copy link
Copy Markdown
Contributor

No worries, I just made a pull request to your repository that adds the ai property.

@t4nk3rchu
Copy link
Copy Markdown

so i merged your pull request now
And for the bug, I tested it with a clean profile but it does not show on my end tho.
Can i ask what other mods did you use? (originally the bug happened in my case because of CMI but it has already been fix)

@CosmoCreeper
Copy link
Copy Markdown
Contributor

So I experience it only on the first install it appears.
I'll double-check everything and if it works without any mods but it enabled then I'll merge it.

@GitDevEnv
Copy link
Copy Markdown
Collaborator

So I experience it only on the first install it appears. I'll double-check everything and if it works without any mods but it enabled then I'll merge it.

What's the status?

@GitDevEnv
Copy link
Copy Markdown
Collaborator

Oh well it got conflicts...

@GitDevEnv
Copy link
Copy Markdown
Collaborator

Ooh, conflicts resolved...

@GitDevEnv
Copy link
Copy Markdown
Collaborator

@t4nk3rchu What's the status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants