Fix reasoning_effort option not being passed to API#32
Open
rdslw wants to merge 1 commit intosimonw:mainfrom
Open
Fix reasoning_effort option not being passed to API#32rdslw wants to merge 1 commit intosimonw:mainfrom
rdslw wants to merge 1 commit intosimonw:mainfrom
Conversation
The reasoning_effort option was defined in ReasoningOptions but never extracted in _build_kwargs, so it was silently ignored when using -o reasoning_effort with reasoning models like gpt-5.1. Also added 'minimal' to ReasoningEffortEnum to match the main llm library's enum values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reasoning_effort option was defined in ReasoningOptions but never extracted in _build_kwargs, so it was silently ignored when using -o reasoning_effort with reasoning models like gpt-5.1.
Also added 'minimal' to ReasoningEffortEnum to match the main llm library's enum values.