Fix onboarding weight validation text and negative profile values#303
Open
LarytheLord wants to merge 2 commits intosimonoppowa:developfrom
Open
Fix onboarding weight validation text and negative profile values#303LarytheLord wants to merge 2 commits intosimonoppowa:developfrom
LarytheLord wants to merge 2 commits intosimonoppowa:developfrom
Conversation
Author
|
Pushed a technical follow-up in commit 2e9d76d to make this PR easier to maintain and safer.
This keeps the original bug fixes intact while adding regression coverage for the boundary logic. |
2e9d76d to
b67f9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the onboarding weight validation message and prevents negative values in profile height/weight pickers.
Closes #288
Closes #216
Closes #217
Changes
onboarding_second_page_body.dartvalidateWeight()to returnonboardingWrongWeightLabelinstead ofonboardingWrongHeightLabel.set_height_dialog.dart>= 1) so users cannot scroll into negative heights.set_weight_dialog.dart>= 1) so users cannot scroll into negative weights.Notes
I could not run Flutter tests in this environment because
flutter/dartare not installed here.