Conversation
|
Thanks very much I have very little time and will need to find a way to test this, which will mean there will be a delay in reviewing. Hopefully in the next few weeks |
|
@simonh1000 I could really use this... anyway we can help you test? |
|
This looks good to me. What do you think @AVierwind ? |
simonh1000
left a comment
There was a problem hiding this comment.
Also want @AVierwind's view
|
Seems good to me! |
simonh1000
left a comment
There was a problem hiding this comment.
Changed my mind. Let's just have a config option proxy (i.e. no CLI option) that we just pass directly to proxyServer - we don't need to handle individual options and can let the user set anything they want from the features of the proxy library
|
@simonh1000 I've implemented your proposed change. Now the whole proxy config object is used on proxy creation. However, I left the format of the existing properties (forward, target, protocol) as they are in order to maintain backward compatibility. |
|
Hi @simonh1000, I wanted to check in and see if you've had a chance to review my changes. If there's anything else I need to add, please let me know. |
Adds new option secure to the config. Allows HTTPS requests to self-signed certificates.
The secure flag is set to true if it isn't configured. In that way the behavior stays the same as it was before this change.
Closes Issue #54