Skip to content

Fix incorrect transcelerator label on import confirmation page#3786

Merged
marksvc merged 1 commit intomasterfrom
fix/import-questions-label
Apr 9, 2026
Merged

Fix incorrect transcelerator label on import confirmation page#3786
marksvc merged 1 commit intomasterfrom
fix/import-questions-label

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented Apr 9, 2026

The transcelerator label was used even when importing from paratext on the question confirmation dialog.

Before

import confirmation dialog incorrect label

After

Import confirmation dialog
Open with Devin

This change is Reviewable

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.30%. Comparing base (9071f22) to head (41398d9).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3786   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         622      622           
  Lines       39387    39387           
  Branches     6390     6414   +24     
=======================================
  Hits        32025    32025           
+ Misses       6377     6364   -13     
- Partials      985      998   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksvc marksvc self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@marksvc marksvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marksvc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).


src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-confirmation-dialog/import-questions-confirmation-dialog.component.html line 28 at r1 (raw file):

          <ng-container matColumnDef="after">
            <th mat-header-cell *matHeaderCellDef>{{ t("update_to") }}</th>

I wonder if "Replace with" or "Change to" might communicate better what is happening. But I see that in context of the dialog's explanation at the top, the use of "Update to" is understandable.

@marksvc marksvc merged commit 70622c7 into master Apr 9, 2026
28 of 29 checks passed
@marksvc marksvc deleted the fix/import-questions-label branch April 9, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants