Fix incorrect transcelerator label on import confirmation page#3786
Fix incorrect transcelerator label on import confirmation page#3786
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3786 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 622 622
Lines 39387 39387
Branches 6390 6414 +24
=======================================
Hits 32025 32025
+ Misses 6377 6364 -13
- Partials 985 998 +13 ☔ View full report in Codecov by Sentry. |
marksvc
left a comment
There was a problem hiding this comment.
@marksvc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).
src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-confirmation-dialog/import-questions-confirmation-dialog.component.html line 28 at r1 (raw file):
<ng-container matColumnDef="after"> <th mat-header-cell *matHeaderCellDef>{{ t("update_to") }}</th>
I wonder if "Replace with" or "Change to" might communicate better what is happening. But I see that in context of the dialog's explanation at the top, the use of "Update to" is understandable.
The transcelerator label was used even when importing from paratext on the question confirmation dialog.
Before
After
This change is