Skip to content

SF-3771 Record USFM downloads in the event log#3783

Merged
Nateowami merged 1 commit intomasterfrom
fix/SF-3771
Apr 8, 2026
Merged

SF-3771 Record USFM downloads in the event log#3783
Nateowami merged 1 commit intomasterfrom
fix/SF-3771

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 7, 2026


Open with Devin

This change is Reviewable

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (b691ada) to head (ac2899f).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3783   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         622      622           
  Lines       39322    39322           
  Branches     6415     6415           
=======================================
  Hits        31958    31958           
  Misses       6366     6366           
  Partials      998      998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).


src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metrics-log.component.ts line 190 at r1 (raw file):

    //       I have not localized at this time because these strings are likely to change based on feedback.
    //       When this feature is mature, these should be localized to help Project Administrators.
    const eventTypeMap: { [key: string]: string } = {

Note that ApplyPreTranslationToProjectAsync is missing.

@Nateowami Nateowami enabled auto-merge (squash) April 8, 2026 15:56
Copy link
Copy Markdown
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).


src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metrics-log.component.ts line 190 at r1 (raw file):

Previously, Nateowami wrote…

Note that ApplyPreTranslationToProjectAsync is missing.

Done. Thank you for noticing that!

@Nateowami Nateowami merged commit 50ffeaf into master Apr 8, 2026
21 of 22 checks passed
@Nateowami Nateowami deleted the fix/SF-3771 branch April 8, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants