SF-3771 Record USFM downloads in the event log#3783
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3783 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 622 622
Lines 39322 39322
Branches 6415 6415
=======================================
Hits 31958 31958
Misses 6366 6366
Partials 998 998 ☔ View full report in Codecov by Sentry. |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metrics-log.component.ts line 190 at r1 (raw file):
// I have not localized at this time because these strings are likely to change based on feedback. // When this feature is mature, these should be localized to help Project Administrators. const eventTypeMap: { [key: string]: string } = {
Note that ApplyPreTranslationToProjectAsync is missing.
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metrics-log.component.ts line 190 at r1 (raw file):
Previously, Nateowami wrote…
Note that ApplyPreTranslationToProjectAsync is missing.
Done. Thank you for noticing that!
This change is