Skip to content

SF-3758 Fix crash when two users have the same Paratext id, sanitize import draft crashes#3768

Merged
RaymondLuong3 merged 2 commits intomasterfrom
fix/SF-3758
Apr 9, 2026
Merged

SF-3758 Fix crash when two users have the same Paratext id, sanitize import draft crashes#3768
RaymondLuong3 merged 2 commits intomasterfrom
fix/SF-3758

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 1, 2026

This PR fixes the root cause of the issue (a regression introduced by SF-2788 Reduce calls to the Paratext Registry (#2529)), and updated the SignalR notification to not include a stack trace.


Open with Devin

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Apr 1, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (5ffa804) to head (5d939f2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3768   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         622      622           
  Lines       39382    39387    +5     
  Branches     6390     6414   +24     
=======================================
+ Hits        32019    32025    +6     
+ Misses       6378     6377    -1     
  Partials      985      985           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RaymondLuong3 reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Apr 2, 2026
@Nateowami
Copy link
Copy Markdown
Collaborator

@pmachapman Can you update the title of the PR? I realize it's hard to title this well, but the actual changes are quite different from the title.

@pmachapman pmachapman changed the title SF-3758 An error appears on the "Importing draft" dialog if the project had sync failed. SF-3758 Fix crash when two users have the same Paratext id Apr 8, 2026
@pmachapman
Copy link
Copy Markdown
Collaborator Author

Can you update the title of the PR? I realize it's hard to title this well, but the actual changes are quite different from the title.

@Nateowami Is this title better?

@pmachapman pmachapman changed the title SF-3758 Fix crash when two users have the same Paratext id SF-3758 Fix crash when two users have the same Paratext id, improve import draft crashes Apr 8, 2026
@pmachapman pmachapman changed the title SF-3758 Fix crash when two users have the same Paratext id, improve import draft crashes SF-3758 Fix crash when two users have the same Paratext id, sanitize import draft crashes Apr 8, 2026
@pmachapman pmachapman added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Apr 8, 2026
@RaymondLuong3 RaymondLuong3 merged commit 9071f22 into master Apr 9, 2026
23 of 24 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3758 branch April 9, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants