SF-3743 Fix checking slowdown when a project has many questions

[pmachapman]

This PR addresses speed issue in community checking by adding an index to the questions in IndexedDB, and by modifying change detection to push for the checking component and checking overview component.

---

---

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (50ffeaf) to head (d652cdb).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...pp/src/app/checking/checking/checking.component.ts	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3754      +/-   ##
==========================================
+ Coverage   81.27%   81.30%   +0.03%     
==========================================
  Files         622      622              
  Lines       39322    39382      +60     
  Branches     6391     6390       -1     
==========================================
+ Hits        31958    32019      +61     
+ Misses       6379     6378       -1     
  Partials      985      985              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Nateowami]

My testing confirms a dramatic performance improvement. Thanks for tracking this down. IndexedDB indexes weren't even on my radar.

[RaymondLuong3]

I was able to see the benefit locally for importing questions. I tested some of the other functionality for community checking and it looks like change detection is not working when playing audio. When I record an play audio, the progress is not updating. Can you look into this?

@RaymondLuong3 reviewed 5 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking-overview/checking-overview.component.ts line 476 at r2 (raw file):

    dialogRef.afterClosed().subscribe(() => {
      this.changeDetector.reattach();
      this.changeDetector.markForCheck();

I noticed this when I was importing the questions and wondered if that was part of the change. Personally I think this makes sense since the dialog is open so we do not necessary need to be updating the calling component in the background

Code quote:

    dialogRef.afterClosed().subscribe(() => {
      this.changeDetector.reattach();
      this.changeDetector.markForCheck();

---

src/SIL.XForge.Scripture/ClientApp/src/app/core/models/question-doc.ts line 25 at r2 (raw file):

      [obj<Question>().pathStr(n => n.projectRef)]: 1,
      [obj<Question>().pathStr(n => n.verseRef.bookNum)]: 1,
      [obj<Question>().pathStr(n => n.verseRef.chapterNum)]: 1

So this makes it easier for loading questions by book and chapter because these values are now indexed, is that correct? Does this benefit both in the context of querying for all questions in a book and for a book and chapter? I could not tell based on my testing.

Code quote:

      [obj<Question>().pathStr(n => n.projectRef)]: 1,
      [obj<Question>().pathStr(n => n.verseRef.bookNum)]: 1,
      [obj<Question>().pathStr(n => n.verseRef.chapterNum)]: 1

[pmachapman]

When I record an play audio, the progress is not updating. Can you look into this?

Done. Thank you!

@pmachapman made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on RaymondLuong3).

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking-overview/checking-overview.component.ts line 476 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

I noticed this when I was importing the questions and wondered if that was part of the change. Personally I think this makes sense since the dialog is open so we do not necessary need to be updating the calling component in the background

It helped the speed of the import to not refresh the background list of questions so often while an import was occurring. It does still happen due to other change detection updates, but at a much lower rate.

---

src/SIL.XForge.Scripture/ClientApp/src/app/core/models/question-doc.ts line 25 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

So this makes it easier for loading questions by book and chapter because these values are now indexed, is that correct? Does this benefit both in the context of querying for all questions in a book and for a book and chapter? I could not tell based on my testing.

Yes. The index will be used if you query by book and chapter, or book, or chapter.

[RaymondLuong3]

Thanks! I am still seeing some issues. When I record an answer and stop the recording, the change detection doesn't appear to run so that the audio is not shown as recorded before saving.

@RaymondLuong3 reviewed 4 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/app/core/models/question-doc.ts line 25 at r2 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Yes. The index will be used if you query by book and chapter, or book, or chapter.

Excellent!

[RaymondLuong3]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

[pmachapman]

When I record an answer and stop the recording, the change detection doesn't appear to run so that the audio is not shown as recorded before saving.

I think I have isolated the cause. Does this issues still occur for you?

@pmachapman made 1 comment, resolved 1 discussion, and dismissed @RaymondLuong3 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[RaymondLuong3]

Thanks! That looks great!. I see another issue. When attaching scripture to an answer, the change detection doesn't run and closing the dialog does not show which scripture is selected. It seems like we should check every component that is in the component tree of checking.component and make sure change detection is run.

@RaymondLuong3 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[pmachapman]

When attaching scripture to an answer, the change detection doesn't run and closing the dialog does not show which scripture is selected. It seems like we should check every component that is in the component tree of checking.component and make sure change detection is run.

I couldn't recreate this exact scenario, but did notice a lag, so I have added change detection to the answer/comment input scenarios, which it looked like the UI would change.

@pmachapman made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[RaymondLuong3]

Now it is working as I would expected. Let's see what testers spots. Thanks!

@RaymondLuong3 partially reviewed 3 files and made 1 comment.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on pmachapman).

[RaymondLuong3]

@RaymondLuong3 reviewed 5 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).