Conversation
jasonleenaylor
requested changes
Mar 6, 2026
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on mark-sil).
Src/xWorks/RecordClerk.cs line 312 at r1 (raw file):
if (decorator == null) break; da = decorator.BaseSda;
I think the RecordClerk is not the class that should actually be subscribing. The decorator that implements OnItemDataModified should actually be the one subscribed eliminating all this ugliness. May as well do that.
Code quote:
var da = m_list.VirtualListPublisher;
while (da != null)
{
if (da.GetType().GetMethod("OnItemDataModified") != null)
ReflectionHelper.CallMethod(da, "OnItemDataModified", new [] {argument});
var decorator = da as DomainDataByFlidDecoratorBase;
if (decorator == null)
break;
da = decorator.BaseSda;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is