Change Number bounds from Int to Scientific.#18
Open
tvh wants to merge 1 commit intosilkapp:masterfrom
tvh:scientific-bound
Open
Change Number bounds from Int to Scientific.#18tvh wants to merge 1 commit intosilkapp:masterfrom tvh:scientific-bound
Int to Scientific.#18tvh wants to merge 1 commit intosilkapp:masterfrom
tvh:scientific-bound
Conversation
This allows validation on all values regardless of size of `maxBound`.
Member
|
In principle this sounds good, I think. However, it seems the |
Member
|
We have a floatingOrInteger check in rest-gen for dealing with this difference, does this change hit some other code path? I'd prefer to have two AST items for floating and integral types. I use integrals pretty much exclusively with json-schema. It's a breaking change either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows validation on all values regardless of size of
maxBound.If this is merged, the code from PR #17 would change with sane bounds.