Use arbitrary_len to avoid arbitrary VariableLists overconsuming input#81
Merged
Use arbitrary_len to avoid arbitrary VariableLists overconsuming input#81
arbitrary_len to avoid arbitrary VariableLists overconsuming input#81Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 49.89% 50.00% +0.10%
==========================================
Files 13 13
Lines 463 462 -1
==========================================
Hits 231 231
+ Misses 232 231 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaelsproul
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
arbitraryimpl forVariableListoften consumes large amounts of the availableUnstructuredbuffer due to selecting a randomusizethen capping at the max size of the list. Certain types usingVariableListcan contain very large max sizes (such asMaxBytesPerTransaction) and so these lists tend to completely consume the available buffer immediately and then pad with zeroes.We should change the implementation to use
arbitrary_lenwhich scales the size of the returned value with the size of the remainingUnstructuredbuffer. This ensures we end up with many smaller lists vs one giant list filled mostly with zeroes.