Read module's version from module's composer.json instead of setup_version attribute of module.xml#67
Open
KoolAndTheHamiltonGang wants to merge 1 commit intosignifyd:mainfrom
Open
Conversation
…rsion attribute of module.xml
|
Any news on the topic? I'm having the same issue @ebanolopes |
Author
|
@ebanolopes for your information Adyen removed setup_version since version >= 9.4.1 https://github.com/Adyen/adyen-magento2/blob/main/etc/module.xml |
|
Same issue with lastest Adyen version ... @ebanolopes can you look this PR ? ❤️ |
ChristopheFerreboeuf
approved these changes
Jun 18, 2024
|
Hello @ChristopheFerreboeuf, |
|
Any news ? :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read module's version from module's composer.json instead of setup_version attribute of module.xml
This fix issues for Adyen >= 9.4.1