Skip to content

Reorder priority for conflicting datasets#142

Merged
Teque5 merged 2 commits intosigmf:mainfrom
cguo02:reorder-conflicting-dataset-priority
Mar 20, 2026
Merged

Reorder priority for conflicting datasets#142
Teque5 merged 2 commits intosigmf:mainfrom
cguo02:reorder-conflicting-dataset-priority

Conversation

@cguo02
Copy link
Contributor

@cguo02 cguo02 commented Mar 20, 2026

Our team is running into an edge case where we have datasets that contain conflicting non-conforming dataset (NCD) and sigmf compliant data files. For example, we have filename.sigmf-meta, filename.cdif, and filename.sigmf-data, where the sigmf-meta has core:dataset set to filename.cdif. Currently, if we use fromfile to read in filename.sigmf-meta, it will pair the meta file with the sigmf-data file rather than the cdif. Given the SigMF spec, we would expect that if core:dataset is set, that means we have a NCD (even if a sigmf-data file with a matching filename exists), thus the file specified by core:dataset should be prioritized over the sigmf-data file.

From the spec:
The full filename of the Dataset file this Metadata file describes, used ONLY with Non-Conforming Datasets
If a Recording does not have this field, it MUST have a compliant SigMF Dataset (NOT a Non-Conforming Dataset) which MUST use the same base filename as the Metadata file and use the .sigmf-data extension

@Teque5
Copy link
Collaborator

Teque5 commented Mar 20, 2026

Issue Makes sense to me - especially since it's called out in the spec. I added a related test. Thanks for the PR.

@Teque5 Teque5 merged commit 241ed97 into sigmf:main Mar 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants