test(tabs): improve flaky tab toolbar test#1758
Merged
spike-rabbit merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refines an E2E test for si-tabs by adding an explicit assertion for the tooltip's text content. The review suggests further improving the test's robustness by using a more generic locator for the tooltip and asserting its exact text content with toHaveText instead of toContainText to prevent potential flakiness.
spliffone
force-pushed
the
test/stabalize-flaky-tab-test
branch
from
4efff8a to
4fc0a53
Compare
spike-rabbit
requested changes
Mar 26, 2026
spliffone
force-pushed
the
test/stabalize-flaky-tab-test
branch
from
4bb1420 to
2800fc1
Compare
spike-rabbit
approved these changes
Mar 26, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Lets hope this helps solving the flakyness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: