Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors several Angular component test files to adopt the new signal-based input/output binding APIs and improve test assertions. The changes include migrating from ComponentRef.setInput() to inputBinding() and outputBinding() with signals, replacing vi.spyOn(component.instance.event, 'emit') with direct vi.fn() for outputs, and updating DOM assertions to use more semantic matchers like toHaveTextContent(), toHaveClass(), toBeDisabled(), and not.toBeInTheDocument(). A test case for handling an undefined link input in si-link.directive.spec.ts was removed during the refactoring and should be re-added to maintain test coverage.
0c55686 to
342d289
Compare
| let component: ComponentRef<TestComponent>; | ||
| let element: HTMLElement; | ||
|
|
||
| const heading = signal<TranslatableString>('Test heading'); |
There was a problem hiding this comment.
| const heading = signal<TranslatableString>('Test heading'); | |
| const heading: WritableSignal<string>; |
and assignement in before each
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: