refactor(search-bar): use icon size to calculate space#1749
Merged
spike-rabbit merged 1 commit intomainfrom Mar 25, 2026
Merged
refactor(search-bar): use icon size to calculate space#1749spike-rabbit merged 1 commit intomainfrom
spike-rabbit merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames a CSS class from ps-9 to icon-start in the search bar component's HTML and defines the new icon-start class in the SCSS. The new class calculates padding-inline-start using Sass map functions. A review comment highlighted a potential issue where map.get(variables.$spacers, 4) could return null if the key is not found, leading to invalid CSS, and suggested adding a compile-time check for robustness.
timowolf
approved these changes
Mar 25, 2026
timowolf
approved these changes
Mar 25, 2026
spike-rabbit
force-pushed
the
refactor/search-bar-use-icons-size-for-gap
branch
3 times, most recently
from
4b9d0ed to
4777948
Compare
timowolf
force-pushed
the
refactor/search-bar-use-icons-size-for-gap
branch
from
4777948 to
8b2c692
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: