feat(forms): align input colors with guidelines#1732
Draft
robertwilde wants to merge 3 commits intomainfrom
Draft
feat(forms): align input colors with guidelines#1732robertwilde wants to merge 3 commits intomainfrom
robertwilde wants to merge 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the styling of form elements, including checkboxes, radio buttons, input fields, and switches, to align with new semantic tokens. This involves changes to background colors, border colors, and text colors for various states like hover, active, checked, and disabled. The review highlights an invalid CSS property border: 1; in the switch component, which should be corrected to border: 1px solid .... Additionally, it points out a visibility issue in the checked radio button's active state where the ::after element's background color matches the primary active background, making it invisible, and suggests using $element-action-primary-text for consistency.
robertwilde
force-pushed
the
feat/forms/colors
branch
2 times, most recently
from
0499591 to
a9e6730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1608
Closes #1609
Updated colors for checkbox, radio, switch and text input in alignment with iX.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: