feat(threshold): add useAliasForStepValues input to display alias labels#1728
Open
chintankavathia wants to merge 1 commit intomainfrom
Open
feat(threshold): add useAliasForStepValues input to display alias labels#1728chintankavathia wants to merge 1 commit intomainfrom
chintankavathia wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the useAliasForStepValues input to the threshold component, which is a useful feature. The implementation is solid, with corresponding updates to the API documentation, component logic, template, and tests. The new tests are comprehensive and cover the new functionality well.
I have one suggestion to improve the template's readability and maintainability by extracting a complex, repeated condition into a computed signal, in line with the project's style guide.
chintankavathia
force-pushed
the
feat/threshold/alias-for-step-value
branch
3 times, most recently
from
e0a5423 to
ca12f34
Compare
chintankavathia
force-pushed
the
feat/threshold/alias-for-step-value
branch
from
ca12f34 to
74b4a60
Compare
Add a `useAliasForStepValues` input that replaces numeric step inputs with readonly text fields showing alias labels. When enabled, add/delete step buttons are hidden. Adds `aliasLabel` property to `ThresholdStep`.
chintankavathia
force-pushed
the
feat/threshold/alias-for-step-value
branch
from
74b4a60 to
29c8fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
useAliasForStepValuesinput that replaces numeric step inputs with readonly text fields showing alias labels. When enabled, add/delete step buttons are hidden. AddsaliasLabelproperty toThresholdStep.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: