feat(microchart-progress): improve accessibility#1672
Open
akashsonune wants to merge 1 commit intomainfrom
Open
feat(microchart-progress): improve accessibility#1672akashsonune wants to merge 1 commit intomainfrom
akashsonune wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the accessibility of the si-microchart-progress component by adding appropriate ARIA attributes. The implementation is a good step forward. However, to ensure the component is always accessible, the new ariaLabel input should be required, as an accessible name is crucial for a progress bar. Additionally, the repository's contribution guidelines require that new features are accompanied by unit tests, which appear to be missing for this new functionality.
projects/native-charts-ng/microchart-progress/si-microchart-progress.component.ts
Outdated
Show resolved
Hide resolved
dr-itz
reviewed
Mar 18, 2026
projects/native-charts-ng/microchart-progress/si-microchart-progress.component.html
Outdated
Show resolved
Hide resolved
akashsonune
force-pushed
the
feat/improve-accessibility-micro-progress-chart
branch
2 times, most recently
from
a85aa50 to
135fd59
Compare
akashsonune
force-pushed
the
feat/improve-accessibility-micro-progress-chart
branch
4 times, most recently
from
f52ed49 to
d832927
Compare
spike-rabbit
requested changes
Mar 25, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
I like the idea, just the aria-label needs some improvement.
akashsonune
force-pushed
the
feat/improve-accessibility-micro-progress-chart
branch
from
d832927 to
eb0374a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: