feat: add DD table files to supplement file handling#3671
Draft
feat: add DD table files to supplement file handling#3671
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bdero
force-pushed
the
bdero/cascade-limiter
branch
from
4ba3c79 to
7777015
Compare
bdero
changed the title
Include App.dd.link and App.dd_callers.link in the list of supplement files that are copied between snapshot directories during patch builds. These files are produced by the 2-pass release build and used by the linker's winner voting algorithm to resolve DD slot mappings.
Allows overriding the Dynamic Dispatch table cascade byte threshold when creating a release. Passed to Flutter tools via the SHOREBIRD_DD_MAX_BYTES environment variable for backwards compatibility: older Flutter builds that don't recognize the variable will silently ignore it. Usage: shorebird release ios --dd-max-bytes=5000
bdero
force-pushed
the
bdero/cascade-limiter
branch
from
cc39a11 to
7e14b32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.dd.linkandApp.dd_callers.linkto the supplement file list so they get copied between snapshot directories during patch builds.aot_toolsduring patch linking for DD slot resolution via winner voting.Test plan