feat: toggle service links in deployments#187
Merged
Tom Bojer (tombojer) merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
6bb55f2 to
bd4086f
Compare
Patrick Derks (TrayserCassa)
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for configuring the
enableServiceLinksfield in container specifications throughout the codebase. This allows users to control whether Kubernetes injects service environment variables into containers. The changes ensure that this field is properly handled in the API, merged correctly, propagated to all relevant Kubernetes workload specs, and thoroughly tested.API and Spec Updates:
EnableServiceLinksfield toContainerSpecandContainerMergeSpec, with appropriate defaulting and deepcopy logic for safe copying. [1] [2] [3] [4]Merging Logic:
Mergemethod forContainerSpecto correctly merge theEnableServiceLinksfield fromContainerMergeSpec.Propagation to Workloads:
AdminDeployment,StorefrontDeployment,WorkerDeployment,ScheduledTaskJob,SetupJob,MigrationJob,snapshotJob,getJobSpec,DebugPod) to setEnableServiceLinksfrom the container spec. [1] [2] [3] [4] [5] [6] [7] [8] [9]Testing:
EnableServiceLinksin container specs and workload generation. [1] [2] [3]Helper Functions:
boolPtrhelper in test files to simplify pointer creation for boolean fields. [1] [2] [3]