feat: add tags and use ephemeral volumes for snapshot archives#183
Merged
Christos Vontas (cv711) merged 7 commits intomainfrom Mar 16, 2026
Merged
feat: add tags and use ephemeral volumes for snapshot archives#183Christos Vontas (cv711) merged 7 commits intomainfrom
Christos Vontas (cv711) merged 7 commits intomainfrom
Conversation
Christos Vontas (cv711)
requested review from
Copilot and
Kevin Rudde (kevinrudde)
and removed request for
Kevin Rudde (kevinrudde)
Christos Vontas (cv711)
force-pushed
the
feat/snapshot-tags
branch
from
2fb85e9 to
a293759
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Christos Vontas (cv711)
changed the title
Contributor
Author
|
Implements also #178 |
Patrick Derks (TrayserCassa)
approved these changes
Mar 16, 2026
Tim Lange (drzombey)
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for attaching labels to snapshots, allowing metadata to be passed from Kubernetes jobs through the CLI and ultimately stored in S3 as object tags. The implementation ensures consistent label ordering to avoid unnecessary job restarts and propagates labels throughout the snapshot creation and upload process.
Label support and propagation:
--labelCLI flag tocmd/snapshot/snapshot.gofor specifying snapshot labels, and implemented parsing of label strings into a map for use in the snapshot context. [1] [2]internal/job/snapshot.goto pass labels from Kubernetes job metadata as CLI arguments, ensuring consistent ordering by sorting label keys.SnapshotContextstruct to include aLabelsfield for label propagation throughout the snapshot process.S3 upload enhancements:
internal/snapshot/s3.goto accept the full snapshot context and attach user-specified labels as S3 object tags, along with a defaultobject-typetag. [1] [2]internal/snapshot/archive.goto pass the snapshot context instead of just the backup file URL.Job configuration improvements:
Dependency and import updates:
stringsandsortpackages to support label parsing and ordering. [1] [2]