Skip to content

Use php configs in extension examples#2160

Merged
Su (sushmangupta) merged 10 commits intomainfrom
use-php-configs-in-extension-examples
Mar 16, 2026
Merged

Use php configs in extension examples#2160
Su (sushmangupta) merged 10 commits intomainfrom
use-php-configs-in-extension-examples

Conversation

@umutdogan4291
Copy link
Contributor

No description provided.

@umutdogan4291 Umut Dogan (umutdogan4291) marked this pull request as draft March 3, 2026 09:01
@umutdogan4291 Umut Dogan (umutdogan4291) marked this pull request as ready for review March 3, 2026 14:04
@Isengo1989
Copy link
Contributor

Umut Dogan (@umutdogan4291) I saw some code block still using xml in the migration guide. Some where adopted in that folder tho, not sure if this needs fixing. Could you please check?

2026-03-16_14-21

@umutdogan4291
Copy link
Contributor Author

Umut Dogan (Umut Dogan (@umutdogan4291)) I saw some code block still using xml in the migration guide. Some where adopted in that folder tho, not sure if this needs fixing. Could you please check?

2026-03-16_14-21

Hi Micha Hobert (@Isengo1989)

I thought those files must be updated once this issue is done shopware/shopware#15351
But if Lars Kemper (@larskemper) thinks different I can update all in this PR.

@mitelg
Copy link
Member

it should not matter if the service definitions are made in XML in the project, which you want to extend 🤔

@Isengo1989
Copy link
Contributor

it should not matter if the service definitions are made in XML in the project, which you want to extend 🤔

I thought this was a company-wide decision, and sooner or later, all will (have to) adapt.

it should not matter if the service definitions are made in XML in the project, which you want to extend 🤔

I thought SwagMigrations also moved to php def. already like commercial shopware/shopware#13072 (comment)

Umut Dogan (@umutdogan4291)

Fine by me to keep it like this, just trying to avoid confusion early on

@larskemper
Copy link
Member

Lars Kemper (larskemper) commented Mar 16, 2026

I thought those files must be updated once this issue is done shopware/shopware#15351 But if Lars Kemper (Lars Kemper (@larskemper)) thinks different I can update all in this PR.

You can already update these. Im currently migrating to php service definitions 🙌
But I can also update these later 🤝

@sushmangupta Su (sushmangupta) merged commit bd06b99 into main Mar 16, 2026
8 checks passed
@sushmangupta Su (sushmangupta) deleted the use-php-configs-in-extension-examples branch March 16, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants