Skip to content

Fix OrderOperation::count()#136

Merged
mdumoulin merged 1 commit intomasterfrom
fix_orderoperation_count
Jan 7, 2026
Merged

Fix OrderOperation::count()#136
mdumoulin merged 1 commit intomasterfrom
fix_orderoperation_count

Conversation

@mdumoulin
Copy link
Copy Markdown
Contributor

@mdumoulin mdumoulin commented Jan 7, 2026

Reason for this PR

The OrderOperation::count() method no longer works as expected.

Steps to reproduce

  • Given I add operations to OrderOperation :
$operation = new OrderOperation();
$operation
    ->accept('ORDER123', 'ChannelA')
    ->cancel('ORDER456', 'ChannelB')
    ->ship('ORDER789', 'ChannelC');
  • When I count operations
$operation->count()

Observed bug on master

  • Then I get 0

Expected result on branch

  • Then I get 3

@mdumoulin mdumoulin self-assigned this Jan 7, 2026
@mdumoulin mdumoulin added the bug Something isn't working label Jan 7, 2026
@mdumoulin mdumoulin merged commit 2c94908 into master Jan 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants