Increase ko build strategy default resource limits#2149
Increase ko build strategy default resource limits#2149officialasishkumar wants to merge 1 commit intoshipwright-io:mainfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pull-request-size
bot
added
the
size/S
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The ko build strategy's default resource limits (500m CPU / 1Gi memory) are too low for Go compilation, causing OOM kills even for simple projects. This increases the limits to 1 CPU / 2Gi memory to match the buildah strategy which has similar resource demands. The memory request is also increased from 65Mi to 256Mi to better reflect the baseline memory needs of the Go compiler. Fixes shipwright-io#2011 Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
officialasishkumar
force-pushed
the
increase-ko-strategy-resources
branch
from
effe567 to
a19d55f
Compare
2 participants
Changes
The ko build strategy's default resource limits (500m CPU / 1Gi memory) are too low for Go compilation, causing OOM kills even for simple projects. This updates both v1alpha1 and v1beta1 ko
ClusterBuildStrategysamples:The new limits match the buildah strategy, which has similar resource demands due to compilation. The memory request is increased to better reflect the baseline memory needs of the Go compiler and toolchain.
Test Plan
Fixes #2011