build(dep): allow rand 0.10 in addition to 0.9#116
build(dep): allow rand 0.10 in addition to 0.9#116tisonkun wants to merge 1 commit intoshepmaster:mainfrom
Conversation
|
Pretty sure this won't (shouldn't?) work as rand changed their MSRV. |
Fair enough. Thanks for triggering the CI workflow. I'm working on bumping rand to 0.10 in fastrace as well and meet the same issue (fast/fastrace#162). Will |
I don't know. I have not yet decided what this crates relation between MSRV and SemVer will be. Another annoying thing is that in many cases I can just widen the dependency version (e.g. One possible solution, like I do over in SNAFU, is to have a feature flag like
There's not really a strong reason to do so, so I doubt it. Can you expand on how this crate's edition impacts you? |
Oh, that's only in the testing code? That might be fine then. Let me noodle for a bit. |
|
I've force pushed to your branch after rebasing it and widening the rand dependency. Doing so has un-verified your commit (as it should). Once I've got CI passing, please do whatever additional testing you'd like against this new version of the code and then rebase it yourself and re-verify it. |
Signed-off-by: tison <wander4096@gmail.com>
cc @shepmaster