Skip to content

build(dep): allow rand 0.10 in addition to 0.9#116

Open
tisonkun wants to merge 1 commit intoshepmaster:mainfrom
tisonkun:rand-010
Open

build(dep): allow rand 0.10 in addition to 0.9#116
tisonkun wants to merge 1 commit intoshepmaster:mainfrom
tisonkun:rand-010

Conversation

@tisonkun
Copy link
Copy Markdown

@shepmaster
Copy link
Copy Markdown
Owner

Pretty sure this won't (shouldn't?) work as rand changed their MSRV.

@tisonkun
Copy link
Copy Markdown
Author

tisonkun commented Feb 19, 2026

Pretty sure this won't (shouldn't?) work as rand changed their MSRV.

Fair enough. Thanks for triggering the CI workflow.

I'm working on bumping rand to 0.10 in fastrace as well and meet the same issue (fast/fastrace#162).

Will twox-hash upgrade MSRV and edition recently or have a plan to do that?

@shepmaster
Copy link
Copy Markdown
Owner

Will twox-hash upgrade MSRV

I don't know. I have not yet decided what this crates relation between MSRV and SemVer will be.

Another annoying thing is that in many cases I can just widen the dependency version (e.g. rand = "~0.9, ~0.10") because the specific code paths that I use don't change from version to version. Unfortunately, it looks like rand did change them this time.

One possible solution, like I do over in SNAFU, is to have a feature flag like rust-1.85. Then I think I could use rand 0.9 in not(rust-1.85) and rand 0.10 otherwise.

Will twox-hash upgrade [..] edition

There's not really a strong reason to do so, so I doubt it. Can you expand on how this crate's edition impacts you?

@shepmaster
Copy link
Copy Markdown
Owner

Unfortunately, it looks like rand did change them this time.

Oh, that's only in the testing code? That might be fine then. Let me noodle for a bit.

@shepmaster
Copy link
Copy Markdown
Owner

shepmaster commented Feb 19, 2026

I've force pushed to your branch after rebasing it and widening the rand dependency. Doing so has un-verified your commit (as it should).

Once I've got CI passing, please do whatever additional testing you'd like against this new version of the code and then rebase it yourself and re-verify it.

Signed-off-by: tison <wander4096@gmail.com>
@shepmaster shepmaster changed the title build(dep): upgrade to rand 0.10 build(dep): allow rand 0.10 in addition to 0.9 Feb 19, 2026
@shepmaster shepmaster added the maintenance Keeping the wheels turning label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Keeping the wheels turning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants