Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| setup. | ||
|
|
||
| The | ||
| [config/README.md file](https://github.com/sharetribe/web-template/tree/main/config/README.md) |
Contributor
There was a problem hiding this comment.
Suggested change
| [config/README.md file](https://github.com/sharetribe/web-template/tree/main/config/README.md) | |
| [config/README.md file](https://github.com/sharetribe/web-template/blob/main/src/config/README.md) |
Missing src directory, but it also changes it to 'blob' for me when I fix it?
| environment variables. You should also check | ||
| The Sharetribe Template webpack configuration is based on the now | ||
| deprecated Create React App (CRA). The template uses Webpack's DevServer | ||
| for providing Hot Module Reloading feature. In some environments, |
Contributor
There was a problem hiding this comment.
Suggested change
| for providing Hot Module Reloading feature. In some environments, | |
| for providing the Hot Module Reloading feature. In some environments, |
| [CRA's advanced configurations](https://create-react-app.dev/docs/advanced-configuration) | ||
| if you experience problems with socket ports. | ||
| if you experience problems with socket ports. Most of these advanced | ||
| configurations are still used in the template, but it's best to ensure |
Contributor
There was a problem hiding this comment.
Maybe some clarification on what to ensure - I assume the suggestion is to check that the variable is not already in use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main documentation assets for the CRA eject are