Skip to content

fix: show networkFeeError at trade confirm#12197

Merged
kaladinlight merged 1 commit intodevelopfrom
estimate-gas-trade-error
Mar 19, 2026
Merged

fix: show networkFeeError at trade confirm#12197
kaladinlight merged 1 commit intodevelopfrom
estimate-gas-trade-error

Conversation

@kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Mar 19, 2026

This change got merged to release after the release already went out (UI wasn't fresh showing the release as open when I was looking). New PR to get fix into develop for next release.

#12192

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling for network fee estimation failures. Users now receive clear error alerts when network fees cannot be calculated, with the trade button disabled to prevent incomplete transactions.

@kaladinlight kaladinlight requested a review from a team as a code owner March 19, 2026 19:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19b156ce-eb12-429c-ad90-9b9eb9ce6927

📥 Commits

Reviewing files that changed from the base of the PR and between 2a70c34 and 7cca061.

📒 Files selected for processing (2)
  • src/components/MultiHopTrade/components/TradeConfirm/TradeConfirmFooter.tsx
  • src/components/MultiHopTrade/components/TradeConfirm/TradeFooterButton.tsx

📝 Walkthrough

Walkthrough

The changes add error handling for network fee estimation failures in the trade confirmation flow. The network fee error is captured from a hook, propagated to the footer button component via props, and used to display error messages and disable the trade action when errors occur.

Changes

Cohort / File(s) Summary
Trade Confirmation Error Handling
src/components/MultiHopTrade/components/TradeConfirm/TradeConfirmFooter.tsx, src/components/MultiHopTrade/components/TradeConfirm/TradeFooterButton.tsx
Added network fee error capture and propagation. TradeConfirmFooter extracts networkFeeError from the fee hook and passes it to TradeFooterButton. TradeFooterButton displays an error alert when present, turns the button red, and disables it during network fee errors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a skip, a gentle catch—
When fees fail, I sound the match!
With warnings red and buttons gray,
We safely guard the trading way. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: show networkFeeError at trade confirm' clearly and concisely describes the main change: displaying network fee errors on the trade confirmation screen.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch estimate-gas-trade-error
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kaladinlight kaladinlight merged commit d9f17f4 into develop Mar 19, 2026
4 checks passed
@kaladinlight kaladinlight deleted the estimate-gas-trade-error branch March 19, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant