fix: move workspace cetusprotocol dependecies into swapper package#12195
fix: move workspace cetusprotocol dependecies into swapper package#12195kaladinlight merged 2 commits intodevelopfrom
Conversation
📝 WalkthroughWalkthroughDependencies related to the Cetus protocol ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/swapper/package.json (1)
34-35: Moving Cetus dependencies into published package is correct.This ensures npm consumers of
@shapeshiftoss/swapperreceive these as direct transitive dependencies, eliminating reliance on workspace hoisting. Both@cetusprotocol/aggregator-sdk@1.4.2and@cetusprotocol/cetus-sui-clmm-sdk@5.4.0are valid and published.Consider consistent version range strategy.
One dependency uses caret (
^1.4.2) while the other is pinned (5.4.0). For maintainability, standardize the approach—either pin both or use caret ranges for both.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/swapper/package.json` around lines 34 - 35, The package.json currently declares `@cetusprotocol/aggregator-sdk` as "^1.4.2" and `@cetusprotocol/cetus-sui-clmm-sdk` as "5.4.0", causing inconsistent version-range strategy; update the dependency entries for `@cetusprotocol/aggregator-sdk` and `@cetusprotocol/cetus-sui-clmm-sdk` to follow a single consistent policy (e.g., both caret ranges "^1.4.2" and "^5.4.0" or both pinned "1.4.2" and "5.4.0") so consumers get predictable transitive deps and maintainability is improved, and ensure only these two dependency name tokens are changed in package.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/swapper/package.json`:
- Around line 34-35: The package.json currently declares
`@cetusprotocol/aggregator-sdk` as "^1.4.2" and `@cetusprotocol/cetus-sui-clmm-sdk`
as "5.4.0", causing inconsistent version-range strategy; update the dependency
entries for `@cetusprotocol/aggregator-sdk` and `@cetusprotocol/cetus-sui-clmm-sdk`
to follow a single consistent policy (e.g., both caret ranges "^1.4.2" and
"^5.4.0" or both pinned "1.4.2" and "5.4.0") so consumers get predictable
transitive deps and maintainability is improved, and ensure only these two
dependency name tokens are changed in package.json.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 223f67b9-5e56-4cf2-9033-825c571a08ef
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.jsonpackages/swapper/package.json
💤 Files with no reviewable changes (1)
- package.json
Description
Moves @cetusprotocol/aggregator-sdk and @cetusprotocol/cetus-sui-clmm-sdk from the root package.json into packages/swapper/package.json as direct dependencies, so that consumers of the published @shapeshiftoss/swapper npm package get these transitive deps resolved correctly instead of relying on phantom hoisting.
Summary by CodeRabbit