Skip to content

fix: move workspace cetusprotocol dependecies into swapper package#12195

Merged
kaladinlight merged 2 commits intodevelopfrom
fix-swapper-dependencies
Mar 19, 2026
Merged

fix: move workspace cetusprotocol dependecies into swapper package#12195
kaladinlight merged 2 commits intodevelopfrom
fix-swapper-dependencies

Conversation

@kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Mar 19, 2026

Description

Moves @cetusprotocol/aggregator-sdk and @cetusprotocol/cetus-sui-clmm-sdk from the root package.json into packages/swapper/package.json as direct dependencies, so that consumers of the published @shapeshiftoss/swapper npm package get these transitive deps resolved correctly instead of relying on phantom hoisting.

Summary by CodeRabbit

  • Chores
    • Updated swapper package to version 17.6.11
    • Updated package dependencies

@kaladinlight kaladinlight requested a review from a team as a code owner March 19, 2026 17:46
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

Dependencies related to the Cetus protocol (@cetusprotocol/aggregator-sdk and @cetusprotocol/cetus-sui-clmm-sdk) were removed from the root package.json and added to packages/swapper/package.json. The swapper package version was incremented from 17.6.9 to 17.6.11.

Changes

Cohort / File(s) Summary
Dependency Migration
package.json, packages/swapper/package.json
Moved Cetus protocol dependencies (@cetusprotocol/aggregator-sdk and @cetusprotocol/cetus-sui-clmm-sdk) from root to swapper sub-package; bumped swapper version to 17.6.11.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop! Dependencies take flight,
From root down to swapper so right,
Cetus protocols find their place,
Version bumped with grace and pace! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and directly describes the main change: moving Cetus protocol dependencies from workspace root to the swapper package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-swapper-dependencies
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/swapper/package.json (1)

34-35: Moving Cetus dependencies into published package is correct.

This ensures npm consumers of @shapeshiftoss/swapper receive these as direct transitive dependencies, eliminating reliance on workspace hoisting. Both @cetusprotocol/aggregator-sdk@1.4.2 and @cetusprotocol/cetus-sui-clmm-sdk@5.4.0 are valid and published.

Consider consistent version range strategy.

One dependency uses caret (^1.4.2) while the other is pinned (5.4.0). For maintainability, standardize the approach—either pin both or use caret ranges for both.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/swapper/package.json` around lines 34 - 35, The package.json
currently declares `@cetusprotocol/aggregator-sdk` as "^1.4.2" and
`@cetusprotocol/cetus-sui-clmm-sdk` as "5.4.0", causing inconsistent version-range
strategy; update the dependency entries for `@cetusprotocol/aggregator-sdk` and
`@cetusprotocol/cetus-sui-clmm-sdk` to follow a single consistent policy (e.g.,
both caret ranges "^1.4.2" and "^5.4.0" or both pinned "1.4.2" and "5.4.0") so
consumers get predictable transitive deps and maintainability is improved, and
ensure only these two dependency name tokens are changed in package.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/swapper/package.json`:
- Around line 34-35: The package.json currently declares
`@cetusprotocol/aggregator-sdk` as "^1.4.2" and `@cetusprotocol/cetus-sui-clmm-sdk`
as "5.4.0", causing inconsistent version-range strategy; update the dependency
entries for `@cetusprotocol/aggregator-sdk` and `@cetusprotocol/cetus-sui-clmm-sdk`
to follow a single consistent policy (e.g., both caret ranges "^1.4.2" and
"^5.4.0" or both pinned "1.4.2" and "5.4.0") so consumers get predictable
transitive deps and maintainability is improved, and ensure only these two
dependency name tokens are changed in package.json.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 223f67b9-5e56-4cf2-9033-825c571a08ef

📥 Commits

Reviewing files that changed from the base of the PR and between 92507df and 3a05887.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • packages/swapper/package.json
💤 Files with no reviewable changes (1)
  • package.json

@kaladinlight kaladinlight merged commit 2a70c34 into develop Mar 19, 2026
4 checks passed
@kaladinlight kaladinlight deleted the fix-swapper-dependencies branch March 19, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant