-
Notifications
You must be signed in to change notification settings - Fork 201
feat: chainflip lending dashboard revamp #12189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gomesalexandre
wants to merge
19
commits into
develop
Choose a base branch
from
feat/chainflip-lending-dashboard-revamp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,431
β840
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d0254d5
feat: chainflip lending dashboard revamp
gomes-bot 6a34d67
fix: visual polish - init view art, info cards, markets table
gomes-bot ad4ebd8
fix: use exact figma svgs for init view art
gomes-bot 7c98de8
fix: remove duplicate apy in supply input modal
gomes-bot d298039
fix: remove unused collateralWithFiat in borrowed section
gomes-bot e80cab5
fix: use figma svgs for next steps card art in sidebar
gomes-bot 81fa802
fix: match next steps button sizes to figma (40px height, xl radius)
gomes-bot 704caf7
fix: visual polish pass 2 - filled buttons, column headers, supply coβ¦
gomes-bot 25eee23
fix: format sidebar jsx props for readability
gomes-bot a449e1e
fix: update chainflip lending revamp ui fixture for new dashboard layout
gomes-bot 30186a4
fix: address coderabbit review comments
gomes-bot 7ac147d
fix: also fix handleViewDashboard stale state in withdraw and collateβ¦
gomes-bot fae220c
fix: visual polish pass 3 - withdraw arrow, solid empty CTAs, sidebarβ¦
gomes-bot a487b3c
fix: sidebar button font size consistency
gomes-bot 6bc7cb3
fix: visual polish pass 4 - dashed empty borders, outline withdraw, wβ¦
gomes-bot a4584c3
fix: visual polish pass 5 - repay prefix, liquidation arrow, section β¦
gomes-bot 9f7d329
feat: visual polish and UX improvements for Chainflip Lending dashboard
gomes-bot 76f9f62
fix: tackle coderabbit review comments
gomes-bot 84a6cc5
Merge branch 'develop' into feat/chainflip-lending-dashboard-revamp
gomesalexandre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,3 +49,4 @@ yarn-error.log* | |
|
|
||
| # translation benchmark data | ||
| scripts/translations/benchmark/ | ||
| .gemini/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,101 @@ | ||
| name: Chainflip Lending Revamp UI | ||
| description: Validates the revamped Chainflip lending surfaces for USDC pool and key action modals. | ||
| description: Validates the revamped Chainflip lending dashboard, init view, funded view with sections, and key action modals. | ||
| route: /chainflip-lending | ||
| steps: | ||
| - name: Chainflip lending dashboard | ||
| instruction: Open the chainflip lending dashboard and ensure the refreshed layout is visible. | ||
| expected: Chainflip lending dashboard cards and market tables are visible. | ||
| # === No-wallet state === | ||
| - name: Landing page without wallet | ||
| instruction: Open the chainflip lending page without a wallet connected. | ||
| expected: > | ||
| Header shows Total Supplied, Available Liquidity, Total Borrowed stat cards. | ||
| "All Markets" section with "Lending Markets" heading, description text, and 6-column table | ||
| (Pool, Supply APY, Total Supplied, Borrow APR, Total Borrowed, Utilisation). | ||
| USDC row shows non-zero APY. Connect Wallet button is visible. | ||
| screenshot: true | ||
| - name: Open usdc pool | ||
| instruction: Navigate into the USDC pool from the All Markets table. | ||
| expected: USDC pool page is visible with action tabs. | ||
|
|
||
| # === Init view (fresh wallet, no positions) === | ||
| - name: Init view for fresh wallet | ||
| instruction: Connect a wallet with no chainflip lending positions. Observe the My Dashboard tab. | ||
| expected: > | ||
| Hero card with "Get Started" badge, "Deposit your first asset to get started" heading, | ||
| blue "+ Deposit" button, "Requires 2 FLIP" note, and asset constellation art (ETH, BTC, USDC, USDT, SOL icons with orbital rings). | ||
| Lending Markets table with 6 columns below. | ||
| Two info cards at bottom: "Earn Yield" (green sparkle art) and "Borrow Against Collateral" (purple refresh art). | ||
| screenshot: true | ||
| - name: Supply modal | ||
| instruction: Open Supply action and verify supply input controls. | ||
| expected: Supply modal is open with amount input, max and submit controls. | ||
|
|
||
| # === Funded dashboard === | ||
| - name: Funded dashboard overview | ||
| instruction: Connect a wallet with free balance on chainflip (e.g. import TorSwapKeyStore4). Navigate to My Dashboard tab. | ||
| expected: > | ||
| Header stat cards: Free Balance (with value), Supplied $0.00, Collateral $0.00, Borrowed $0.00. | ||
| My Dashboard / Markets tabs visible, My Dashboard selected. | ||
| Free Balance section with Asset/Balance columns, listing assets with balances. | ||
| Blue filled "+ Deposit" button and ghost "Withdraw" button in Free Balance header. | ||
| Next Steps sidebar card with green sparkle art, "Supply" and "Add Collateral" buttons. | ||
| screenshot: true | ||
| - name: Deposit and egress modal | ||
| instruction: Open Deposit to Chainflip tab and open Withdraw modal. | ||
| expected: Egress modal is open with destination toggle and amount controls. | ||
|
|
||
| - name: Empty sections display | ||
| instruction: Scroll down on the funded dashboard to see Supplied, Collateral, and Borrowed sections. | ||
| expected: > | ||
| Supplied section: "$0.00", "No earning positions yet" empty state with blue "+ Deposit" button. | ||
| Collateral section: "$0.00", "Provide collateral to start borrowing" with blue "+ Add Collateral" button. | ||
| Borrowed section: "$0.00", "No Active Loans" with blue "+ Add Collateral" button. | ||
| screenshot: true | ||
| - name: Collateral modal ltv gauge | ||
| instruction: Open Collateral tab and open Add Collateral modal. | ||
| expected: LTV gauge shows target, soft liquidation and hard liquidation labels without overlap. | ||
|
|
||
| # === Action modals from dashboard === | ||
| - name: Deposit modal from dashboard | ||
| instruction: Click the blue "+ Deposit" button in the Free Balance section header. | ||
| expected: > | ||
| Deposit modal opens. Asset selector card with icon, name, balance visible. | ||
| Amount input field with asset icon. Info rows below divider. | ||
| Blue "Next" button at bottom. | ||
| screenshot: true | ||
| - name: Borrow modal | ||
| instruction: Open Manage Loan tab and open Borrow modal. | ||
| expected: Borrow modal is open with amount input and target LTV section. | ||
|
|
||
| - name: Supply modal from Next Steps | ||
| instruction: Close deposit modal. Click "Supply" button in the Next Steps sidebar card. | ||
| expected: > | ||
| Supply modal opens with "Asset to supply" selector card. | ||
| Pool APY and Current Position stat boxes side-by-side. | ||
| Amount input with asset icon. Info rows: Estimated yearly earnings, Pool Share, Auto-compounding, Risk band. | ||
| Blue "Next" button at bottom. | ||
| screenshot: true | ||
| - name: Repay modal | ||
| instruction: Open Repay modal from Manage Loan tab. | ||
| expected: Repay modal is open with full repayment toggle and amount controls. | ||
|
|
||
| - name: Add Collateral modal | ||
| instruction: Close supply modal. Click "+ Add Collateral" button from the Collateral section empty state. | ||
| expected: > | ||
| Add Collateral modal opens with asset selection, amount input, and LTV gauge preview. | ||
| screenshot: true | ||
|
|
||
| # === Loan Health / LTV bar === | ||
| - name: Loan Health bar (requires active loan) | ||
| instruction: > | ||
| If the wallet has an active loan (collateral posted + borrowed amount > 0), | ||
| verify the Loan Health card appears above the section cards on My Dashboard. | ||
| It should show: heart rate monitor icon, "Loan Health" label, Current LTV percentage | ||
| (color-coded green/yellow/red), Liquidation Distance fiat value on the right, | ||
| and a horizontal multi-segment bar (Safe green / Risky yellow / Liquidation red) | ||
| with a skull icon at the hard liquidation boundary. | ||
| If no active loan exists, the Loan Health card should NOT render (this is correct). | ||
| expected: > | ||
| Loan Health card renders when loans exist with LTV gauge bar, | ||
| or correctly hidden when no loans. | ||
| data-testid: chainflip-lending-loan-health | ||
| screenshot: true | ||
|
|
||
| # === Visual polish checks === | ||
| - name: Empty section dashed borders | ||
| instruction: > | ||
| On the funded dashboard with no supply/collateral/borrowed positions, | ||
| verify that the Supplied, Collateral, and Borrowed section cards have | ||
| dashed borders (not solid) to visually indicate empty state. | ||
| expected: > | ||
| Empty section cards have dashed border style. Free Balance card (with data) has solid border. | ||
| screenshot: true | ||
|
|
||
| # === Markets tab === | ||
| - name: Markets tab | ||
| instruction: Close any open modal. Switch to the "Markets" tab. | ||
| expected: > | ||
| Lending Markets heading with description. | ||
| 6-column table (Pool, Supply APY, Total Supplied, Borrow APR, Total Borrowed, Utilisation). | ||
| USDC and Tether rows show non-zero APY and utilisation. | ||
| screenshot: true | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.