Skip to content

Fix KeyError for packages with versions #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharkwouter wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix KeyError for packages with versions #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e929c1
Fix KeyError for packages with versions
sharkwouter Feb 21, 2025
0105ca3
Handle KeyError when determining date
sharkwouter Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions piprot/piprot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,13 @@ def get_version_and_release_date(

try:
if version:
if version in response["releases"]:
if version in response.get("releases", []):
release_date = response["releases"][version][0]["upload_time"]
else:
elif response.get("urls"):
for download in response['urls']:
if download["packagetype"] == "sdist":
release_date = download['upload_time']
if not release_date:
return None, None
else:
version = response["info"].get("stable_version")
Expand All @@ -209,7 +213,7 @@ def get_version_and_release_date(
return version, datetime.fromtimestamp(
time.mktime(time.strptime(release_date, "%Y-%m-%dT%H:%M:%S"))
)
except IndexError:
except (IndexError, KeyError):
if verbose:
print("{} ({}) didn't return a date property".format(requirement, version))
return None, None
Expand Down