Restore canonical path building behavior on windows (Closing #1077) #1108
Draft
AdamGS wants to merge 2 commits intoservo:mainfrom
Draft
Restore canonical path building behavior on windows (Closing #1077) #1108AdamGS wants to merge 2 commits intoservo:mainfrom
AdamGS wants to merge 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1077.
Currently, only two exact formats for the first segment are handled — a 2-byte literal drive letter (C:) or a 4-byte percent-encoded one (C%3A). Anything else was rejected. The new code percent-decodes the entire first segment, which means it now handles segments that contain the full path with encoded separators, like
C%3A%5CUsers%5CmeorC:%2FUsers%2Fme.Handling this case restores the ability to roundtrip this kind of cases through
to_file_path, whichobject_storeand a bunch of crates depending on it, also just seems more robust.